Monero: add more legacy verify functions #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no-std CI failure is legitimate, processor/coordinator/full-stack aren't (they're some Docker connectivity issue). I've re-run them. |
|
I appreciate 46f4370, yet if you want to make further RPC changes, I'd appreciate it on a distinct PR. By the way, one of the biggest changes we can make for performance will be moving to |
kayabaNerve
reviewed
Oct 22, 2023
I have added this type for borromen sigs, the ee field can be a normal scalar as in the verify function the ee field is checked against a reduced scalar mean for it to verify as correct ee must be reduced
this matches Monero I have also changed a couple varint functions to accept the `VarInt` trait
I still need to revert the commit removing support for >1 input MLSAG FULL This adds a new rct type to separate Full and simple rct
also added `#[allow(clippy::needless_range_loop)]` around a loop as without a re-write satisfying clippy without it will make the function worse.
plus other misc changes
This function was causing me problems, every now and then a node would return a block with a different number than requested.
Monero calculates the POW hash and the block hash using *slightly* different blobs :/
|
Will merge once CI passes 👍 Thanks for the effort :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367
UnreducedScalartype which has a method for recovering scalars which underwent an incorrect reduction