machete, drain > mem::swap for clarity reasons

serai-dex · Sep 20, 2024 · d40a772 · d40a772
1 parent 862ab5c
commit d40a772
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 14 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/processor/bin/src/lib.rs b/processor/bin/src/lib.rs
@@ -284,21 +284,19 @@ pub async fn main_loop<
             let key_to_activate =
               KeyToActivate::<KeyFor<S>>::try_recv(txn.as_mut().unwrap()).map(|key| key.0);
 
-            /*
-              `acknowledge_batch` takes burns to optimize handling returns with standard payments.
-              That's why handling these with a Batch (and not waiting until the following potential
-              `queue_burns` call makes sense. As for which Batch, the first is equally valid unless
-              we want to start introspecting (and should be our only Batch anyways).
-            */
-            let mut this_batchs_burns = vec![];
-            std::mem::swap(&mut burns, &mut this_batchs_burns);
-
             // This is a cheap call as it internally just queues this to be done later
             let _: () = scanner.acknowledge_batch(
               txn.take().unwrap(),
               id,
               in_instructions,
-              this_batchs_burns,
+              /*
+                `acknowledge_batch` takes burns to optimize handling returns with standard
+                payments. That's why handling these with a Batch (and not waiting until the
+                following potential `queue_burns` call makes sense. As for which Batch, the first
+                is equally valid unless we want to start introspecting (and should be our only
+                Batch anyways).
+              */
+              burns.drain(..).collect(),
               key_to_activate,
             );
           }

diff --git a/processor/ethereum/Cargo.toml b/processor/ethereum/Cargo.toml
@@ -32,7 +32,6 @@ k256 = { version = "^0.13.1", default-features = false, features = ["std"] }
 
 alloy-core = { version = "0.8", default-features = false }
 alloy-rlp  = { version = "0.3", default-features = false }
-alloy-consensus = { version = "0.3", default-features = false }
 
 alloy-rpc-types-eth = { version = "0.3", default-features = false }
 alloy-transport = { version = "0.3", default-features = false }

diff --git a/processor/ethereum/router/Cargo.toml b/processor/ethereum/router/Cargo.toml
@@ -18,7 +18,6 @@ workspace = true
 
 [dependencies]
 group = { version = "0.13", default-features = false }
-k256 = { version = "^0.13.1", default-features = false, features = ["std", "ecdsa", "arithmetic"] }
 
 alloy-core = { version = "0.8", default-features = false }
 alloy-consensus = { version = "0.3", default-features = false }