add missing prevotes (#590)

* add missing prevotes * remove the TODO * add missing current step checks --------- Co-authored-by: akildemir <[email protected]>
serai-dex · Aug 14, 2024 · bf1c493 · bf1c493
1 parent 3de1e4d
commit bf1c493
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/coordinator/tributary/tendermint/src/lib.rs b/coordinator/tributary/tendermint/src/lib.rs
@@ -708,9 +708,17 @@ impl<N: Network + 'static> TendermintMachine<N> {
     if let Data::Proposal(_, block) = &msg.data {
       match self.network.validate(block).await {
         Ok(()) => {}
-        Err(BlockError::Temporal) => return Err(TendermintError::Temporal),
+        Err(BlockError::Temporal) => {
+          if self.block.round().step == Step::Propose {
+            self.broadcast(Data::Prevote(None));
+          }
+          Err(TendermintError::Temporal)?;
+        }
         Err(BlockError::Fatal) => {
           log::warn!(target: "tendermint", "validator proposed a fatally invalid block");
+          if self.block.round().step == Step::Propose {
+            self.broadcast(Data::Prevote(None));
+          }
           self
             .slash(
               msg.sender,
@@ -729,6 +737,9 @@ impl<N: Network + 'static> TendermintMachine<N> {
           target: "tendermint",
           "proposed proposed with a syntactically invalid valid round",
         );
+        if self.block.round().step == Step::Propose {
+          self.broadcast(Data::Prevote(None));
+        }
         self
           .slash(msg.sender, SlashEvent::WithEvidence(Evidence::InvalidValidRound(msg.encode())))
           .await;