Add Jedis pool metrics binder #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
|
@munishchouhan this adds an Prometheus exporter for the Redis connection metrics. Ca =n you please validate and add the charts in the Redis section in Grafana? |
pditommaso
commented
Nov 26, 2024
src/main/groovy/io/seqera/wave/redis/JedisPoolMetricsBinder.groovy
Outdated
Show resolved
Hide resolved
|
Validated: |
Signed-off-by: munishchouhan <[email protected]>
pditommaso
commented
Dec 4, 2024
|
Nice. Is there already a PR for the Grafana dashboard? |
Working on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Micrometer metrics binder to export Jedis pool via Promeheus.
Tagging @swampie for visibility