Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve credentials error message consider docker.io as default repo #581

Closed
wants to merge 7 commits into from
Closed

Improve credentials error message consider docker.io as default repo #581

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1089f98
corrected error message
munishchouhan Jul 25, 2024
4b97de4
add docker.io check in creds
munishchouhan Jul 25, 2024
c9f0401
Merge branch 'master' into 580-getting-missing-credentials-for-target…
munishchouhan Jul 30, 2024
3564765
Merge branch 'master' into 580-getting-missing-credentials-for-target…
munishchouhan Aug 13, 2024
322f9af
Merge branch 'master' into 580-getting-missing-credentials-for-target…
munishchouhan Sep 13, 2024
be6c4b7
Merge branch 'master' into 580-getting-missing-credentials-for-target…
munishchouhan Sep 18, 2024
e821c00
Merge branch 'master' into 580-getting-missing-credentials-for-target…
munishchouhan Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/groovy/io/seqera/wave/service/inspect/ContainerInspectServiceImpl.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ class ContainerInspectServiceImpl implements ContainerInspectService {
if( cacheRepo )
repos.add(cacheRepo)
final result = credsJson(repos, identity)
if( buildRepo && result && !result.contains(host0(buildRepo)) )
if( buildRepo && !result.contains(host0(buildRepo)) || !result.contains('docker.io') )
throw new BadRequestException("Missing credentials for target build repository: $buildRepo")
if( cacheRepo && result && !result.contains(host0(cacheRepo)) )
throw new BadRequestException("Missing credentials for target cache repository: $buildRepo")
if( cacheRepo && (!result.contains(host0(cacheRepo)) || !result.contains('docker.io')) )
throw new BadRequestException("Missing credentials for target cache repository: $cacheRepo")
return result
}

Expand Down