[FIX] Correctly propagate the constness of the inner range type. #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rrahn
force-pushed
the
fix/propagate_const_in_simd_view
branch
from
a89446b
to
a539f67
Compare
seqan-actions
added
lint
eseiler
approved these changes
Jul 4, 2024
Instead of using the value type of the underlying range we use the reference type, such that in case the original range is passed in as const it is correctly propagated to the inner range type. Otherwise, we might end in the situation that we want to assign a const iterator to a non-const iterator which is not allowed.
rrahn
force-pushed
the
fix/propagate_const_in_simd_view
branch
from
a539f67
to
e7a373b
Compare
seqan-actions
added
lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the value type of the underlying range we use the reference type, such that in case the original range is passed in as const it is correctly propagated to the inner range type. Otherwise, we might end in the situation that we want to assign a const iterator to a non-const iterator which is not allowed.