[INFRA] Add IntelLLVM CI #3225
Merged
[INFRA] Add IntelLLVM CI #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3225 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 269 269
Lines 11854 11854
=======================================
Hits 11638 11638
Misses 216 216 ☔ View full report in Codecov by Sentry. |
eseiler
force-pushed
the
infra/intel_ci
branch
from
48f29be
to
c42acc3
Compare
seqan-actions
added
lint
seqan-actions
added
lint
seqan-actions
added
lint
eseiler
force-pushed
the
infra/intel_ci
branch
from
08a7113
to
db9a4ea
Compare
seqan-actions
added
lint
eseiler
force-pushed
the
infra/intel_ci
branch
from
db9a4ea
to
047507e
Compare
seqan-actions
added
lint
SGSSGene
approved these changes
Jan 30, 2024
eseiler
force-pushed
the
infra/intel_ci
branch
from
047507e
to
5ea70ac
Compare
seqan-actions
added
lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second commit:
The result of
is erroneous due to some optimization (the Intel compiler uses some more aggressive optimization by default). The cast is probably undefined (or at least unspecified) behavior.
Usually, this is because the value is not properly bound to
ininThis also occasionally happens with other compilers.
My solution is to either use the left or right byte, depending on the endianness. Since we cast to
uint16_t, and only compare one byte, the correct byte should be either of the two. Currently, we do not officially support / test big endian archs.