Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround compiling with debug mode #3222

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

SGSSGene
Copy link
Contributor

This is for fixing #3221

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
seqan3 ✅ Ready (Inspect) Visit Preview Jan 17, 2024 11:00am

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97f908b) 98.17% compared to head (3322897) 98.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3222   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         269      269           
  Lines       11854    11854           
=======================================
  Hits        11638    11638           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseiler
Copy link
Member

eseiler commented Jan 16, 2024

Is this bug specific for gcc12? If so, we should only disable constexpr vector literals for gcc12 with glibcxx_debug.

@SGSSGene
Copy link
Contributor Author

Is this bug specific for gcc12? If so, we should only disable constexpr vector literals for gcc12 with glibcxx_debug.

The issues shows in all gccs version (tried newest gcc10-gcc13): https://godbolt.org/z/oTfhEWrvd

Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Just two minor things

include/seqan3/core/platform.hpp Outdated Show resolved Hide resolved
include/seqan3/core/platform.hpp Show resolved Hide resolved
@eseiler eseiler linked an issue Jan 17, 2024 that may be closed by this pull request
2 tasks
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 17, 2024
@eseiler eseiler self-requested a review January 17, 2024 11:02
@eseiler eseiler enabled auto-merge (squash) January 17, 2024 11:03
@eseiler eseiler merged commit 646b6a2 into seqan:master Jan 17, 2024
30 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compiling with _GLIBCXX_DEBUG gives errors
3 participants