-
Notifications
You must be signed in to change notification settings - Fork 82
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3199 from eseiler/test/api
[FIX] API tests
- Loading branch information
Showing
3 changed files
with
58 additions
and
2 deletions.
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
test/api_stability/3.3.0/0001-FIX-take_until_view_test.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
From e89261cd4f2dfdffe982e8c95af1666acf9cfc47 Mon Sep 17 00:00:00 2001 | ||
From: Enrico Seiler <[email protected]> | ||
Date: Thu, 28 Sep 2023 21:28:37 +0200 | ||
Subject: [PATCH 1/2] [FIX] take_until_view_test | ||
|
||
mutable refers to the capture | ||
--- | ||
test/unit/io/views/detail/take_until_view_test.cpp | 5 +++-- | ||
1 file changed, 3 insertions(+), 2 deletions(-) | ||
|
||
diff --git a/test/unit/io/views/detail/take_until_view_test.cpp b/test/unit/io/views/detail/take_until_view_test.cpp | ||
index 970a3a1b1..8f34f7014 100644 | ||
--- a/test/unit/io/views/detail/take_until_view_test.cpp | ||
+++ b/test/unit/io/views/detail/take_until_view_test.cpp | ||
@@ -131,10 +131,11 @@ TEST(view_take_until, concepts) | ||
do_concepts(adapt, true); | ||
|
||
// mutable adapters make the view lose const-iterability | ||
+ char c2 = 'a'; | ||
auto adapt2 = seqan3::detail::take_until( | ||
- [count = 0](char c) mutable | ||
+ [c2](char c) mutable | ||
{ | ||
- ++count; | ||
+ c2 = 'b'; | ||
return c == '\n'; | ||
}); | ||
do_concepts(adapt2, false); | ||
-- | ||
2.42.0 | ||
|
25 changes: 25 additions & 0 deletions
25
test/api_stability/3.3.0/0002-FIX-Change-constexpr-test.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
From e3eaa3f826fbab51db415d0dd6cbf8a93ecad153 Mon Sep 17 00:00:00 2001 | ||
From: Enrico Seiler <[email protected]> | ||
Date: Thu, 28 Sep 2023 19:35:57 +0200 | ||
Subject: [PATCH 2/2] [FIX] Change constexpr test | ||
|
||
gcc11 complains suddenly | ||
--- | ||
.../core/range/detail/adaptor_for_view_without_args_test.cpp | 3 +-- | ||
1 file changed, 1 insertion(+), 2 deletions(-) | ||
|
||
diff --git a/test/unit/core/range/detail/adaptor_for_view_without_args_test.cpp b/test/unit/core/range/detail/adaptor_for_view_without_args_test.cpp | ||
index 54bcb640c..460fab223 100644 | ||
--- a/test/unit/core/range/detail/adaptor_for_view_without_args_test.cpp | ||
+++ b/test/unit/core/range/detail/adaptor_for_view_without_args_test.cpp | ||
@@ -21,6 +21,5 @@ TEST(adaptor_combination, constexpr_combine) | ||
{ | ||
constexpr auto adaptor1 = seqan3::detail::adaptor_for_view_without_args<dummy_view>{}; | ||
constexpr auto adaptor2 = seqan3::detail::adaptor_for_view_without_args<dummy_view>{}; | ||
- | ||
- EXPECT_TRUE((SEQAN3_IS_CONSTEXPR(adaptor1 | adaptor2))); | ||
+ [[maybe_unused]] static constinit auto combined = adaptor1 | adaptor2; | ||
} | ||
-- | ||
2.42.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8a4d68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
seqan3 – ./
seqan3-seqan.vercel.app
seqan3.vercel.app
seqan3-git-master-seqan.vercel.app