Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Fix sanitizer #258

Merged
merged 2 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/ci_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ defaults:
jobs:
build:
name: ${{ matrix.compiler }}
runs-on: macos-12
runs-on: macos-14
if: github.repository_owner == 'seqan' || github.event_name == 'workflow_dispatch' || github.event.label.name == 'lint'
strategy:
fail-fast: false
Expand All @@ -46,10 +46,11 @@ jobs:
compiler: ${{ matrix.compiler }}
ccache_size: 75M

- name: Install CMake
uses: seqan/actions/setup-cmake@main
- name: Patch M1 GCC
if: contains(matrix.compiler, 'gcc') && matrix.compiler != 'gcc-14'
uses: seqan/actions/patch-m1-gcc@main
with:
cmake: 3.28.5
compiler: ${{ matrix.compiler }}

- name: Configure tests
run: |
Expand Down
19 changes: 13 additions & 6 deletions .github/workflows/ci_sanitizer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ concurrency:

env:
TZ: Europe/Berlin
ASAN_OPTIONS: strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1:detect_leaks=1
TSAN_OPTIONS: ignore_noninstrumented_modules=1
UBSAN_OPTIONS: print_stacktrace=1

Expand All @@ -24,22 +23,24 @@ jobs:
name: ${{ matrix.name }} ${{ matrix.build_type }} ${{ matrix.os }}
runs-on: ${{ matrix.os }}
if: github.repository_owner == 'seqan' || github.event_name == 'workflow_dispatch'
env:
ASAN_OPTIONS: strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1:detect_leaks=${{ contains(matrix.os, 'macos') && '0' || '1' }}
strategy:
fail-fast: false
matrix:
name: [ASan, TSan, UBSan]
os: [ubuntu-latest, macos-12]
os: [ubuntu-latest, macos-14]
build_type: [Release, RelWithDebInfo, Debug]
exclude:
- name: "TSan"
os: macos-12
os: macos-14
include:
- name: "ASan"
os: ubuntu-latest
cxx_flags: "-fno-omit-frame-pointer -fsanitize=address -Wno-maybe-uninitialized -Wno-interference-size"

- name: "ASan"
os: macos-12
os: macos-14
cxx_flags: "-fno-omit-frame-pointer -fsanitize=address"

- name: "TSan"
Expand All @@ -50,10 +51,10 @@ jobs:
cxx_flags: "-fno-omit-frame-pointer -fsanitize=undefined,float-divide-by-zero -Wno-interference-size"

- name: "UBSan"
os: macos-12
os: macos-14
cxx_flags: "-fno-omit-frame-pointer -fsanitize=undefined,float-divide-by-zero,local-bounds,nullability -fno-sanitize=function -Wno-pass-failed"

- os: macos-12
- os: macos-14
compiler: clang-18

- os: ubuntu-latest
Expand All @@ -78,6 +79,12 @@ jobs:
with:
compiler: ${{ matrix.compiler }}

- name: Patch M1 GCC
if: contains(matrix.compiler, 'gcc') && matrix.compiler != 'gcc-14'
uses: seqan/actions/patch-m1-gcc@main
with:
compiler: ${{ matrix.compiler }}

- name: Configure tests
run: |
mkdir build && cd build
Expand Down
6 changes: 3 additions & 3 deletions cmake/package-lock.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# This file should be committed to version control

# hibf
set (CHOPPER_HIBF_VERSION 169cafe1fda30f2b0546cababd5740b282c38aa6)
set (CHOPPER_HIBF_VERSION f85154de1db3d6430db63e16193b87c7bed70b8d)
CPMDeclarePackage (hibf
NAME hibf
GIT_TAG ${CHOPPER_HIBF_VERSION}
Expand All @@ -16,7 +16,7 @@ CPMDeclarePackage (hibf
OPTIONS "INSTALL_HIBF OFF"
)
# sharg
set (CHOPPER_SHARG_VERSION 420193a9642ab34c87c21a8b9ba1dd3e23d2c83a)
set (CHOPPER_SHARG_VERSION c4367d1049322826e60c674b6bf24d3d0a8da999)
CPMDeclarePackage (sharg
NAME sharg
GIT_TAG ${CHOPPER_SHARG_VERSION}
Expand All @@ -26,7 +26,7 @@ CPMDeclarePackage (sharg
OPTIONS "INSTALL_SHARG OFF" "INSTALL_TDL OFF" "CMAKE_MESSAGE_LOG_LEVEL WARNING" "BUILD_TESTING OFF"
)
# seqan3
set (CHOPPER_SEQAN3_VERSION 1fcf9a66a5db46785dc90bc2d1fc6b4acca94fd9)
set (CHOPPER_SEQAN3_VERSION d4a7c88fde0311e12e98e7822da772b99c887cb5)
CPMDeclarePackage (seqan3
NAME seqan3
GIT_TAG ${CHOPPER_SEQAN3_VERSION}
Expand Down