Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Streamline libraries #255

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[INFRA] Streamline libraries #255

merged 1 commit into from
Aug 22, 2024

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Aug 20, 2024

Untitled Diagram drawio (4)

Nothing really changed besides:

  • adding aliases (chopper::*)
  • having interface separately (chopper::interface)

@seqan-actions seqan-actions added lint and removed lint labels Aug 20, 2024
@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/chopper/255

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.72%. Comparing base (91d11e5) to head (83fb59a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   95.72%   95.72%           
=======================================
  Files          20       20           
  Lines         749      749           
  Branches       15       15           
=======================================
  Hits          717      717           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@smehringer smehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to my limited cmake knowledge. I trust you on that. Can you add a comment about why you did these changes? I don't see the immediate benefits.

@eseiler eseiler enabled auto-merge August 22, 2024 10:58
@seqan-actions seqan-actions added lint and removed lint labels Aug 22, 2024
@eseiler eseiler merged commit c3fe1f9 into seqan:main Aug 22, 2024
24 checks passed
@eseiler eseiler deleted the infra/lib branch August 22, 2024 11:03
@eseiler
Copy link
Member Author

eseiler commented Aug 22, 2024

Looks alright to my limited cmake knowledge. I trust you on that. Can you add a comment about why you did these changes? I don't see the immediate benefits.

It just looks more like you would modern cmake to look like (namespaces library aliases, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants