[MISC] Use new layout #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 95.66% 95.58% -0.09%
==========================================
Files 13 13
Lines 646 634 -12
==========================================
- Hits 618 606 -12
Misses 28 28
☔ View full report in Codecov by Sentry. |
smehringer
approved these changes
Aug 26, 2023
include/chopper/configuration.hpp
Outdated
| @@ -86,7 +86,7 @@ struct configuration | |||
| archive(CEREAL_NVP(determine_best_tmax)); | |||
| archive(CEREAL_NVP(force_all_binnings)); | |||
|
|
|||
| archive(CEREAL_NVP(hibf_config)); | |||
| // archive(CEREAL_NVP(hibf_config)); | |||
There was a problem hiding this comment.
Suggested change
| // archive(CEREAL_NVP(hibf_config)); |
There was a problem hiding this comment.
can be done in a follow up pr
|
I'm not sure what exactly you mean by all the open todo points. Maybe we should discuss them before merging this PR. |
eseiler
commented
Aug 28, 2023
| @@ -17,6 +17,7 @@ | |||
| #include <seqan3/utility/range/to.hpp> | |||
| #include <seqan3/utility/views/join_with.hpp> | |||
|
|
|||
| #include "../api/api_test.hpp" | |||
| #include "cli_test.hpp" | |||
|
|
|||
| // check if each chopper submodule can work with the output of the other | |||
There was a problem hiding this comment.
chopper_layout_with_tax // tax is ignored
With TAX, otherwise same as chopper_layout2
eseiler
commented
Aug 28, 2023
|
|
||
| return filenames; | ||
| } | ||
|
|
eseiler
commented
Aug 28, 2023
include/chopper/layout/input.hpp
Outdated
| namespace chopper::layout | ||
| { | ||
|
|
||
| inline void read_config_from(configuration & config, std::istream & stream) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
chopper::configuration::write_to { // Call cereal on members }write_to/read_fromsame as in hibf lib