Solar-charger #365
Open
Solar-charger #365
+542
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use formatted code from main to make future merge more readable
|
@BjoernLuig looking at the solar charger code I still would suggest du create a library the board instead of adding all the code into the blocks. |
mariopesch
requested changes
Dec 10, 2024
| .appendField(", XB") | ||
| .appendField(new Blockly.FieldCheckbox("TRUE"), "POWER_OFF_XB"); | ||
| } | ||
| this.appendDummyInput().appendField(Blockly.Msg.) |
There was a problem hiding this comment.
@BjoernLuig here is something missing, therefore the build process fails
|
I also changed the PR to be merged to development branch first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds usefull blocks for solar operation in a new category.