move start times from 18:30 to 19:00 for most evening slots #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for sharp-babbage-a45ee2 failed.
|
|
We're going to try to merge your branch into develop first, to make sure that we can deploy it all properly. The errors you're seeing here were, we think, fixed in both fix-local and develop. We thought about modifying your branch but decided to be safe and leave it as it is. |
|
@rpruim - We now have your changes plus the fixes we've made running on the develop branch, but it's not signalling a constraint violation on 6:30pm courses. Are you certain the changes you made fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply edits the files containing start times of courses to reflect a change for the 24-25 academic year.
Note: A fancier version of this would take the academic year into account so that courses are not flagged in old schedules. That would require handling academic year more explicitly (which might be a good idea).