-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/standard times issue 300 #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm confused about this PR. It appears the changes it is intended to introduce are already in production. Furthermore, there is a conflict with a subsequent update to the standard meeting patterns. I've twice tried to resolve those on github, but they don't seem to take. I'm going to close this since I don't think it is actually needed. |
Did you push to production on accident at one point? Or were they included with a different feature branch? It seems the latter is most likely (I've done that before). |
I don't think I can push to production. (I tried it once to see if that's what happened and my push was blocked.) I'm not sure just what happened, but if you are interested, this is roughly how things went down (IIRC):
|
Ah yeah, sounds like a complicated git workflow. I wish GitHub had the option to disallow fixing conflicts online. Often times, it doesn't work quite right. |
As per #300, I've made the standard time check a bit looser. This will allow people to schedule classes that meet only one time from a meeting pattern without being flagged.
I've implemented this be expanding the list of legal meeting patterns when it is created to include the one-day versions of teach meeting pattern. Everything else is just as before.
I've added several additional test cases to confirm the new behavior is working as desired.
Side note: See #295. This would be cleaner if I didn't need to convert from TH to R and back again.