Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update version format #20

Merged
merged 3 commits into from
Sep 12, 2023
Merged

chore: update version format #20

merged 3 commits into from
Sep 12, 2023

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Sep 12, 2023

Update version format platform[_framework]_product@version to product-platform[-framework]@version

@bang9 bang9 self-assigned this Sep 12, 2023
Copy link

@jerry-jeon-sb jerry-jeon-sb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

}

function capitalizeProduct(str?: string): string {
if (!str) return ''
if (str === 'uikit') return 'UIKit'
if (str === 'live_uikit') return 'Live_UIKit'
if (str === 'live_uikit' || str === 'live-uikit') return 'Live-UIKit'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼하시네욤 👍

@bang9 bang9 merged commit 429bc07 into main Sep 12, 2023
3 checks passed
@bang9 bang9 deleted the chore/version-format branch September 12, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants