Remove deprecated TcpOptionType

[WojtekMs]

This is a continuation of #1289

Please let me know if you think it's okay to remove the deprecated feature, now that it was already released :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.14%. Comparing base (bdc68bd) to head (124430f).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1615      +/-   ##
==========================================
- Coverage   83.16%   83.14%   -0.03%     
==========================================
  Files         276      276              
  Lines       47288    47191      -97     
  Branches     9616     9498     -118     
==========================================
- Hits        39326    39235      -91     
+ Misses       7076     7072       -4     
+ Partials      886      884       -2     

Flag	Coverage Δ
fedora40	75.25% <100.00%> (-0.03%)	⬇️
macos-13	80.68% <100.00%> (-0.02%)	⬇️
macos-14	80.69% <100.00%> (-0.01%)	⬇️
macos-15	80.66% <100.00%> (-0.01%)	⬇️
mingw32	70.84% <ø> (-0.02%)	⬇️
mingw64	70.79% <ø> (-0.04%)	⬇️
npcap	85.14% <ø> (-0.08%)	⬇️
rhel94	75.12% <100.00%> (+<0.01%)	⬆️
ubuntu2004	58.69% <42.85%> (-0.01%)	⬇️
ubuntu2004-zstd	58.84% <42.85%> (+0.02%)	⬆️
ubuntu2204	75.03% <100.00%> (-0.02%)	⬇️
ubuntu2204-icpx	61.52% <ø> (-0.01%)	⬇️
ubuntu2404	75.31% <100.00%> (+<0.01%)	⬆️
unittest	83.14% <100.00%> (-0.03%)	⬇️
windows-2019	85.25% <ø> (-0.01%)	⬇️
windows-2022	85.27% <ø> (-0.01%)	⬇️
winpcap	85.23% <ø> (+<0.01%)	⬆️
xdp	50.19% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tigercosmos]

The formatting looks bad here. Maybe turn off clang-format here?

[tigercosmos]

Maybe it's better to remove this after one more release, but I am also fine to do it now.

[seladb]

@WojtekMs I think we might want to remove this in future versions

[tigercosmos]

@WojtekMs I think we might want to remove this in future versions

@seladb I guess the next next release may be a proper timing?

[seladb]

@WojtekMs I think we might want to remove this in future versions

@seladb I guess the next next release may be a proper timing?

Yes, I think so 👍

[WojtekMs]

Okay, so for now, maybe I will close this PR?

[Dimi1010]

Okay, so for now, maybe I will close this PR?

I think its fine to keep it open, as a reminder.

[tigercosmos]

I put it in the milestone, so we don't forget it.

[seladb]

We can either leave it open or close it, I don't have a strong opinion