Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Export distribution versions #2014

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Dec 30, 2024

Describe your changes and provide context

Testing performed to validate your change

tools/migration/ss/migrator.go Fixed Show fixed Hide fixed
tools/migration/ss/migrator.go Fixed Show fixed Hide fixed
tools/migration/ss/migrator.go Fixed Show fixed Hide fixed
tools/migration/ss/migrator.go Fixed Show fixed Hide fixed
tools/migration/ss/migrator.go Fixed Show fixed Hide fixed
tools/migration/ss/migrator.go Fixed Show fixed Hide fixed

fmt.Printf(
"[%s] Completed exporting distribution module from %d to %d. Total keys: %d. Duration: %s\n",
time.Now().Format(time.RFC3339), startVersion, endVersion, totalExported, time.Since(startTime),

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism
tools/migration/ss/migrator.go Fixed Show fixed Hide fixed
startVersion, endVersion int64,
) error {
fmt.Printf("Starting export at %s for versions [%d..%d]\n",
time.Now().Format(time.RFC3339), startVersion, endVersion,

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism
)

var totalExported int
startTime := time.Now()

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism
// Optional progress logging every 1,000,000 keys:
if totalExported%1_000_000 == 0 {
fmt.Printf("[SingleWorker][%s] Exported %d distribution keys so far\n",
time.Now().Format(time.RFC3339), totalExported,

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism
}
if stop {
fmt.Printf("[SingleWorker][%s] Iteration stopped early; callback returned true at some point.\n",
time.Now().Format(time.RFC3339),

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism
"[%s] Completed exporting distribution store for versions [%d..%d]. Total keys: %d. Duration: %s\n",
time.Now().Format(time.RFC3339), startVersion, endVersion, totalExported, time.Since(startTime),
)
fmt.Printf("Finished export at %s\n", time.Now().Format(time.RFC3339))

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.53%. Comparing base (e8e4b3b) to head (2ecf3e9).
Report is 234 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2014      +/-   ##
==========================================
- Coverage   61.64%   61.53%   -0.12%     
==========================================
  Files         365      263     -102     
  Lines       26178    24525    -1653     
==========================================
- Hits        16138    15091    -1047     
+ Misses       8967     8309     -658     
- Partials     1073     1125      +52     

see 222 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant