fix race condition #2013
Open
fix race condition #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzang2019
reviewed
Dec 30, 2024
| @@ -349,6 +349,8 @@ func (f *LogFetcher) GetLogsByFilters(ctx context.Context, crit filters.FilterCr | |||
| defer wg.Done() | |||
| defer func() { | |||
| if r := recover(); r != nil { | |||
| mu.Lock() | |||
There was a problem hiding this comment.
Is this being hit at all? I think recover() should never be hit in this logic, and it shouldn't be causing any dead lock issue from my understanding. That being said, adding the lock wouldn't hurt as well
| // Aggregate results into the final slice | ||
| for result := range resultsChan { | ||
| res = append(res, result) | ||
| } | ||
|
|
||
| // Check err after all work is done |
There was a problem hiding this comment.
This ordering adjustment make sense to me, but I wonder why it would lead to dead lock or stuck issue
There was a problem hiding this comment.
I think it'd cause the errorsList = append(errorsList, berr) above to run into undefined behavior which then causes some weirdness
yzang2019
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change