Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Fix 404 when performing task lookup #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikesir87
Copy link
Contributor

Resolves #51

The UI is sending the service name (see below). This updates the API to treat it as the service name, rather than the task family name.

request
.get(`/api/clusters/${cluster}/tasks/${service}`)

@nettofarah
Copy link

The cood looks good to me!
I’m an ECS noob, so I’m not super sure what’s the difference here semantically.

Are you sure this won’t introduce regressions?

@mikesir87
Copy link
Contributor Author

I did wonder if there might be regressions, but tracing through the codebase, it looks like...

  • The API is called only through the code snippet above (not using tasks in one place and service in another)
  • The various backend code is used by only this API

So... it looks like the changes are safe at this point since nothing else is using these various code paths.

@NicolasRitouet
Copy link

@stephenmathieson is this repo still maintained?
This PR is fixing a bug I also have, would be great to see this merged (at least reviewed and commented).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 on /cluster-name/tasks/svc-name
3 participants