Implement Application Completion Workflow with Certificate Generation and Email Notification #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjula-sack
requested changes
Jul 11, 2024
src/utils.ts
Outdated
| const pdfFileName = await generateCertificate( | ||
| name, | ||
| './src/certificates/certificate_template.pdf', | ||
| `./src/certificates/${name}_certificate.pdf` |
There was a problem hiding this comment.
Shall we use a unique id here? There might be a chance of having the same name. Also you need to update the certificate_id field of the mentee with file path as well.
Suggested change
| `./src/certificates/${name}_certificate.pdf` | |
| `./src/certificates/${name}_certificate.pdf` |
There was a problem hiding this comment.
here I used uuid library to generate unique values
anjula-sack
requested changes
Jul 12, 2024
| @@ -12,7 +12,8 @@ export enum EmailStatusTypes { | |||
| export enum ApplicationStatus { | |||
There was a problem hiding this comment.
Shall we rename this to MenteeStatus and create separate one form Mentors? Cuz mentors don't need a completed state.
Suggested change
| export enum ApplicationStatus { | |
| export enum MenteeStatus { |
There was a problem hiding this comment.
For now, could we avoid changing this? There is a lot of refactoring involved.
This commit updates the Mentee entity to use the UUID data type for the `certificate_id` column instead of the `bigint` data type. This change ensures compatibility with the UUID data type in the database and improves data integrity. Co-authored-by: Dileepa Mabulage <[email protected]>
anjula-sack
reviewed
Jul 14, 2024
|
anjula-sack
requested changes
Jul 20, 2024
package.json
Outdated
| "passport-linkedin-oauth2": "github:auth0/passport-linkedin-oauth2#v3.0.0", | ||
| "pg": "^8.10.0", | ||
| "reflect-metadata": "^0.1.13", | ||
| "ts-node": "^10.9.1", | ||
| "typeorm": "^0.3.16" | ||
| "typeorm": "^0.3.16", | ||
| "uuid": "^10.0.0" |
There was a problem hiding this comment.
anjula-sack
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #122
Goals
Approach
To achieve the above goals, the following steps were taken:
Screenshots
Checklist
Related PRs
Test environment
Learning
During the development of this feature, I explored several resources to understand how to effectively use the pdf-lib library for PDF manipulation and how to attach files to emails programmatically. This included reviewing documentation, blog posts, and tutorials related to pdf-lib and email handling in Node.js applications.