Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make implicit intents safe #159

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Pablito2020
Copy link

The current code lacks verification of whether the implicit intent is fulfilled. In my device, I don't have any browser installed and, consequently, when I attempt to trigger an implicit intent by clicking a button to open a URL, the app crashes.

These modifications introduce comprehensive support to enhance the safety of implicit intents. This update addresses the issue by implementing a check to initiate the implicit intent securely. In cases where the implicit intent fails to start, a toast notification is displayed to the user, indicating the absence of an application capable of opening the content. (Note: This error handling can be customized using the onError lambda within the method, although the current approach aligns with the standard practice adopted by most applications.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant