generated from rl-institut/rli_template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/emission constraint #39
Open
yechenyan
wants to merge
11
commits into
dev
Choose a base branch
from
feature/emmission_constrant
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umns Feature/eliminate empty columns
SabineHaas
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @yechenyan! looks good to me!
I won't merge, as I am not sure whether it will be part of this adapter or another repo.
However, I have used the function to get all the inputs for the emission constraint, which was very helpful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new function,
process_emission_constraint_inputs(processes_raw)
, aims to refine the handling of emission constraint data. Below is the detailed workflow and expected transformation:The input(
processes_raw
) to the function is a pandasDataFrame
as shown below:The return value of the function is a pandas
DataFrame
, which update the last row as below:Processing Steps:
If there's a row in the table where the process is
ind_constraintco_2eq
, then execute the subsequent steps.Take all the values in the
output
column that start withemi
, remove duplicates, and place them into theinput
field of the row where the process isind_constraintco_2eq
.Beside, implement necessary test cases to verify the function's effectiveness and accuracy.