test: e2e testing #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluax
requested changes
Nov 2, 2023
There was a problem hiding this comment.
I'll take a more in-depth look at the tests themselves tomorrow morning:
But make side:
Could we prevent these tests from running under the make-unit-cover command? Since these aren't unit tests. Ideally, they would have a separate command make-e2e-test and make-e2e-cover.
gluax
reviewed
Nov 3, 2023
| s.runValidators(s.chain, 0) | ||
| } | ||
|
|
||
| func (s *IntegrationTestSuite) TearDownSuite() { |
There was a problem hiding this comment.
IIRC golang calls this automatically? So the temp files should always get removed even if an error happens right? If not maybe we should consider making these temp files in the /tmp dir instead of locally was what I think I saw.
gluax
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
End-to-end testing is an addition to the current seda-chain testing framework that relies only on unit tests.
Explanation of Changes
The e2e testing runs two chain Docker containers to deploy a local chain. It then sends transactions through Docker command lines and tests the outcomes using HTTP API queries. Once testing is finished, the containers are torn down.
The current implementation tests the three transaction commands in our wasm-storage module:
To run the e2e tests, first build the Docker image using a Makefile command:
You can then run the e2e test with the following command:
Note that to run these tests through VS Code, you may have to adjust the timeout period. The tests take about a minute or two to run.
Related PRs and Issues
Closes #94