feat: add dockerfile that and script that automates node operation #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeancarloBarrios
force-pushed
the
JeancarloBarrios/fix-docker-build-for-arm-arch
branch
from
d094123 to
3ad4c05
Compare
mariocao
requested changes
Oct 11, 2023
There was a problem hiding this comment.
It builds! 🎆
However, I tried to run it but seda-chaind seems not to be working.
$ docker run 6432088abd86
exec /usr/bin/seda-chaind: no such file or directory
From inside the container:
397b6b1416c9:~# seda-chaind
bash: /usr/bin/seda-chaind: cannot execute: required file not found
mariocao
reviewed
Oct 16, 2023
mariocao
reviewed
Oct 17, 2023
mariocao
reviewed
Oct 17, 2023
| #!/bin/bash | ||
| set -e | ||
|
|
||
| # Basic Setup Configurations |
There was a problem hiding this comment.
As a rule of thumb when there is a doubt, it is better not to hardcode default values.
Some values I might like to have as default are:
- chain id
- network
There was a problem hiding this comment.
This are here just for testing purposes final PR will require environmental variables.
mariocao
reviewed
Oct 17, 2023
mariocao
reviewed
Oct 17, 2023
mariocao
reviewed
Oct 17, 2023
|
|
||
| # Start the node | ||
| echo "Starting node ..." | ||
| $BIN start |
There was a problem hiding this comment.
Add this into the dockerfile
Suggested change
| $BIN start |
mariocao
reviewed
Oct 17, 2023
| COPY scripts/validator_setup/validator_setup.sh /usr/local/bin/validator_setup.sh | ||
| RUN chmod +x /usr/local/bin/validator_setup.sh | ||
|
|
||
| ENTRYPOINT ["validator_setup.sh"] |
There was a problem hiding this comment.
Suggested change
| ENTRYPOINT ["validator_setup.sh"] | |
| ENTRYPOINT ["validator_setup.sh"] | |
| CMD ["seda-chaind", "start"] |
JeancarloBarrios
changed the title
mariocao
requested changes
Oct 18, 2023
JeancarloBarrios
force-pushed
the
JeancarloBarrios/fix-docker-build-for-arm-arch
branch
2 times, most recently
from
a3419c0 to
81d6de7
Compare
JeancarloBarrios
force-pushed
the
JeancarloBarrios/fix-docker-build-for-arm-arch
branch
from
81d6de7 to
dcecbe3
Compare
Comment on lines
+126
to
+135
| ifeq (badgerdb,$(findstring badgerdb,$(COSMOS_BUILD_OPTIONS))) | ||
| BUILD_TAGS += badgerdb | ||
| endif | ||
| # handle rocksdb | ||
| ifeq (rocksdb,$(findstring rocksdb,$(COSMOS_BUILD_OPTIONS))) | ||
| ifneq ($(ENABLE_ROCKSDB),true) | ||
| $(error Cannot use RocksDB backend unless ENABLE_ROCKSDB=true) | ||
| endif | ||
| CGO_ENABLED=1 | ||
| endif |
There was a problem hiding this comment.
Do we need these DB checks?
JeancarloBarrios
changed the base branch from
main
to
JeancarloBarrios/add-dockerfile-node-automation
JeancarloBarrios
changed the base branch from
JeancarloBarrios/add-dockerfile-node-automation
to
main
Comment on lines
+71
to
+115
| build_tags = netgo | ||
|
|
||
| # experimental feature | ||
| ifeq ($(EXPERIMENTAL),true) | ||
| build_tags += experimental | ||
| endif | ||
|
|
||
| ifeq ($(LEDGER_ENABLED),true) | ||
| ifeq ($(OS),Windows_NT) | ||
| GCCEXE = $(shell where gcc.exe 2> NUL) | ||
| ifeq ($(GCCEXE),) | ||
| $(error gcc.exe not installed for ledger support, please install or set LEDGER_ENABLED=false) | ||
| else | ||
| build_tags += ledger | ||
| endif | ||
| else | ||
| UNAME_S = $(shell uname -s) | ||
| ifeq ($(UNAME_S),OpenBSD) | ||
| $(warning OpenBSD detected, disabling ledger support (https://github.com/cosmos/cosmos-sdk/issues/1988)) | ||
| else | ||
| GCC = $(shell command -v gcc 2> /dev/null) | ||
| ifeq ($(GCC),) | ||
| $(error gcc not installed for ledger support, please install or set LEDGER_ENABLED=false) | ||
| else | ||
| build_tags += ledger | ||
| endif | ||
| endif | ||
| endif | ||
| endif | ||
|
|
||
| ifeq (secp,$(findstring secp,$(COSMOS_BUILD_OPTIONS))) | ||
| build_tags += libsecp256k1_sdk | ||
| endif | ||
|
|
||
| whitespace := | ||
| whitespace += $(whitespace) | ||
| comma := , | ||
| build_tags_comma_sep := $(subst $(whitespace),$(comma),$(build_tags)) | ||
|
|
||
| ldflags = -X github.com/cosmos/cosmos-sdk/version.Name=seda-chain \ | ||
| -X github.com/cosmos/cosmos-sdk/version.AppName=seda-chaind \ | ||
| -X github.com/cosmos/cosmos-sdk/version.Version=$(VERSION) \ | ||
| -X github.com/cosmos/cosmos-sdk/version.Commit=$(COMMIT) \ | ||
| -X "github.com/cosmos/cosmos-sdk/version.BuildTags=$(build_tags_comma_sep)" \ | ||
| -X github.com/tendermint/tendermint/version.TMCoreSemVer=$(TMVERSION) |
There was a problem hiding this comment.
I think we have this already, no?
Comment on lines
+168
to
+177
| build: BUILD_ARGS=-o $(BUILDDIR)/ | ||
| build-linux: | ||
| @if [ "${ENABLE_ROCKSDB}" != "true" ]; then \ | ||
| echo "RocksDB support is disabled; to build and test with RocksDB support, set ENABLE_ROCKSDB=true"; fi | ||
| GOOS=linux GOARCH=$(if $(findstring aarch64,$(shell uname -m)) || $(findstring arm64,$(shell uname -m)),arm64,amd64) LEDGER_ENABLED=false $(MAKE) build | ||
|
|
||
| $(BUILD_TARGETS): go.sum $(BUILDDIR)/ | ||
| @if [ "${ENABLE_ROCKSDB}" != "true" ]; then \ | ||
| echo "RocksDB support is disabled; to build and test with RocksDB support, set ENABLE_ROCKSDB=true"; fi | ||
| go $@ -mod=readonly $(BUILD_FLAGS) $(BUILD_ARGS) ./... |
There was a problem hiding this comment.
I think it'd be better if build-linux gives us seda-chaind-linux to be distinguished from the output of build?
|
replaced by #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix Dockerfile to be able to build arm builds
Explanation of Changes
(Write your explanation here)
Testing
(Write your test plan here)
Related PRs and Issues
closes #69
(Link your related PRs and Issues here)