Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Add basict test tooling #59

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

JeancarloBarrios
Copy link
Contributor

@JeancarloBarrios JeancarloBarrios commented Sep 27, 2023

Motivation

To improve code quality this PR adds unit testing GH action for our repository modules

Related PRs and Issues

closes #55

(Link your related PRs and Issues here)

@JeancarloBarrios JeancarloBarrios marked this pull request as ready for review September 29, 2023 17:25
@JeancarloBarrios JeancarloBarrios force-pushed the JeancarloBarrios/test-tooling branch 2 times, most recently from 3585dad to d250daa Compare September 29, 2023 17:27
if: steps.cache-binaries.outputs.cache-hit != 'true' && env.GIT_DIFF
uses: actions/setup-go@v4
with:
go-version: "1.21"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.19? perhaps doesn't matter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point .50 has go updated but I will change it then thanks!

- uses: actions/checkout@v4
- uses: actions/setup-go@v4
with:
go-version: "1.21"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@JeancarloBarrios JeancarloBarrios force-pushed the JeancarloBarrios/test-tooling branch from d250daa to 51e752c Compare September 29, 2023 22:50
@JeancarloBarrios JeancarloBarrios merged commit 51e752c into main Sep 29, 2023
5 checks passed
@JeancarloBarrios JeancarloBarrios deleted the JeancarloBarrios/test-tooling branch September 29, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔧 Add Github Action for tests
2 participants