Improve tally integration testing #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacheigriega
commented
Dec 16, 2024
hacheigriega
force-pushed
the
hy/improve-tests
branch
from
9bc597c to
2914e0a
Compare
Thomasvdam
approved these changes
Dec 17, 2024
hacheigriega
force-pushed
the
hy/improve-tests
branch
from
2914e0a to
2f6bc9e
Compare
hacheigriega
force-pushed
the
hy/improve-tests
branch
from
2f6bc9e to
035b083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes
Integration tests for tally and batching have been mostly relying on mocked contract keepers due to the difficulty of setting up the contract state with tally-ready data requests. This PR implements the complete overlay operator stake - data request post - commit & reveal flow so that we can fully test the tally and batch processes.
A simple test of a data request tally has been implemented. More elaborate tally testing and batching testing will be implemented soon.
Testing
This is the test.
Related PRs and Issues
Closes #440