Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support amino signing for data proxy transactions #442

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Thomasvdam
Copy link
Member

Motivation

We want to support data proxy operators utilising hardware wallets (Ledger) for managing a data proxy.

Explanation of Changes

I'm not 100% certain on all the proto amino tags. I looked at various cosmos SDK modules to see how those were implemented and then it was a bunch of trial and error until I got all transactions to pass locally. 🤷

If there's any good sources on what proto annotations we need exactly I'd love to read more!

Testing

Fairly involved local setup where I ran the chain locally using seda-1-planet as the chain ID, enabled CORS for all domains in the config.toml, set up the indexer and explorer locally (and all related services), and used a HTTPS proxy (proxyman) to route traffic from https://rpc.planet.seda.xyz to the local RPC port.

With this entire setup I was able to use a local build of the explorer to sign TXs with amino sign mode. I tried registering a data proxy, editing a single field at a time (payoutAddress, memo, fee, fee+update delay), edit multiple fields at a time, and transferring the admin address. The web code still needs to be cleaned up though, will open that PR tomorrow.

Related PRs and Issues

Part-of: https://github.com/sedaprotocol/seda-explorer/issues/591

@Thomasvdam Thomasvdam requested review from hacheigriega and a team December 11, 2024 21:20
@Thomasvdam Thomasvdam force-pushed the feat/data-proxy-amino branch from ed1f102 to 34dbd56 Compare December 11, 2024 21:21
Copy link
Member

@hacheigriega hacheigriega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am hoping to understand this test setup soon.. Seems very neat.
Is it OK that our other txs don't support amino signing?

@Thomasvdam
Copy link
Member Author

I am hoping to understand this test setup soon.. Seems very neat. Is it OK that our other txs don't support amino signing?

We should definitely test the new create validator and unjail transactions. For the rest I don't think it's urgent, but worth keeping in the back of our minds. :)

@Thomasvdam Thomasvdam force-pushed the feat/data-proxy-amino branch from 34dbd56 to 6b885fa Compare December 12, 2024 08:39
Base automatically changed from fix/tally-result to main December 12, 2024 08:40
@Thomasvdam Thomasvdam merged commit 6b885fa into main Dec 12, 2024
@Thomasvdam Thomasvdam deleted the feat/data-proxy-amino branch December 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants