Publish correct tally completion event values #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariocao
approved these changes
Dec 11, 2024
|
Fat finger, apologies. |
hacheigriega
approved these changes
Dec 11, 2024
Turns out we were accidentally shadowing the `result` variable in the switch statement, which meant that when we assigned result after the statement we used the empty reference with default values.
Thomasvdam
force-pushed
the
fix/tally-result
branch
from
b3428ef to
1939f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow indexing the tally logs and gas used attributes.
Explanation of Changes
Turns out we were accidentally shadowing the
resultvariable in the switch statement, which meant that when we assigned result after the statment we used the empty reference with default values.Testing
Verified that a local node with these changes output the correct events at block #9777 with the (at the time of writing) current planet.
Related PRs and Issues
N.A.