Add default genesis state #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluax
approved these changes
Dec 10, 2024
Also wire up the message server so we can actually send updateParams transactions from the governance module.
Thomasvdam
force-pushed
the
fix/tally-genesis
branch
from
912d7a3 to
67f1956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Without the default genesis state the module ends up in a state where it can't retrieve the max gas limit and all tally executions will just error out. See https://planet.test.explorer.seda.xyz/data-requests/72a0a8a68247202079023a800ef69c742e73fab43dff579bd2229cb5457ca622/894 for an example error.
Also register the message server and interfaces in the app module so we can actually update the params through governance. :)
Explanation of Changes
Implement genesis methods in the module.
Testing
Run a local chain with code added in the tally endblock handler to print the max gas limit every block.
{"level":"info","module":"server","module":"x/tally","max_gas_limit":300000000000000,"time":"2024-12-10T15:12:24+01:00","message":"max tally gas limit"}Related PRs and Issues
N.A.