Fix Lint in CI #185
Closed
Fix Lint in CI #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/app.go
Outdated
| @@ -30,12 +28,15 @@ import ( | |||
| "cosmossdk.io/x/upgrade" | |||
| upgradekeeper "cosmossdk.io/x/upgrade/keeper" | |||
| upgradetypes "cosmossdk.io/x/upgrade/types" | |||
| "github.com/spf13/cast" | |||
app/app.go
Outdated
Comment on lines
33
to
34
| abci "github.com/cometbft/cometbft/abci/types" | ||
| tmproto "github.com/cometbft/cometbft/proto/tendermint/types" |
There was a problem hiding this comment.
shouldn't cometbft go before cosmos or cosmossdk.io?
app/export.go
Outdated
| app.StakingKeeper.SetUnbondingDelegation(ctx, ubd) | ||
| err := app.StakingKeeper.SetUnbondingDelegation(ctx, ubd) | ||
| if err != nil { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
why not be consistent and panic here?
app/simulation_test.go
Outdated
| @@ -10,13 +10,13 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| "cosmossdk.io/log" | |||
| storetypes "cosmossdk.io/store/types" | |||
| evidencetypes "cosmossdk.io/x/evidence/types" | |||
| "github.com/stretchr/testify/require" | |||
cmd/seda-chaind/cmd/root.go
Outdated
Comment on lines
17
to
21
| "github.com/spf13/cast" | ||
| "github.com/spf13/cobra" | ||
| "github.com/spf13/pflag" | ||
| "google.golang.org/grpc" | ||
| "google.golang.org/protobuf/reflect/protoregistry" |
There was a problem hiding this comment.
should go after standard packages but before cometbft/cosmos
cmd/seda-chaind/gentx/gentx.go
Outdated
| address "cosmossdk.io/core/address" | ||
| "cosmossdk.io/errors" | ||
| "github.com/spf13/cobra" |
e2e/e2e_setup_test.go
Outdated
| "github.com/ory/dockertest/v3" | ||
| "github.com/ory/dockertest/v3/docker" | ||
| "github.com/spf13/viper" |
|
The import order of standard -> default -> cometbft -> cosmos -> seed-chain as defined in |
hacheigriega
approved these changes
Jan 26, 2024
jim380
force-pushed
the
jay/fix-lint-ci
branch
from
167353f to
8e460ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #178