[Interchaintest] Installment # 2 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacheigriega
requested changes
Jan 16, 2024
app/app.go
Outdated
| crisistypes.StoreKey, minttypes.StoreKey, distrtypes.StoreKey, slashingtypes.StoreKey, | ||
| govtypes.StoreKey, consensusparamtypes.StoreKey, upgradetypes.StoreKey, | ||
| feegrant.StoreKey, evidencetypes.StoreKey, circuittypes.StoreKey, group.StoreKey, | ||
| govtypes.StoreKey, paramstypes.StoreKey, consensusparamtypes.StoreKey, upgradetypes.StoreKey, |
There was a problem hiding this comment.
I think there is no need to add paramstypes.StoreKey
app/app.go
Outdated
| capabilitytypes.StoreKey, ibcexported.StoreKey, ibctransfertypes.StoreKey, ibcfeetypes.StoreKey, | ||
| wasmtypes.StoreKey, icahosttypes.StoreKey, | ||
| icacontrollertypes.StoreKey, | ||
| ) | ||
|
|
||
| tkeys := storetypes.NewTransientStoreKeys(paramstypes.TStoreKey) |
There was a problem hiding this comment.
Related to previous comment - If we don't need params module, we don't need transient store either
app/app.go
Outdated
| @@ -825,6 +828,7 @@ func NewApp( | |||
|
|
|||
| // initialize stores | |||
| app.MountKVStores(keys) | |||
| app.MountTransientStores(tkeys) | |||
|
Does this PR close Issue #131 ? |
|
Yes |
hacheigriega
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR attempts to achieve the followings:
app.gorefactor & fixesSedaExponentto 6 inapp/params/config.go. This is because in interchaintest v8.0.0 the default only has hardcoded values now which were tailored toe6.Testing
You should see the test passing.