Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interchaintest] Installment # 1 - Foundation #145

Merged
merged 8 commits into from
Jan 9, 2024

Conversation

jim380
Copy link
Contributor

@jim380 jim380 commented Jan 5, 2024

Overview

This PR serves the following purposes:

  1. Fix for ibc tendermint client integration in app.go
  2. The first installment of introducing repeatable and diagnostic tests for IBC functionalities via interchaintest.

Future Installments

  • Chain start test
  • Chain upgrade test
  • Module specific test
  • State sync test
  • Interchain account test
  • Packer forwarder test
  • And more

Testing

Before proceeding, make sure you change SedaExponent to 6 in app/params/config.go. This is because in interchaintest v8.0.0 the default only has hardcoded values now which were tailored to e6.
image

$ docker build --build-arg GITHUB_TOKEN=<> -t sedaprotocol/seda-chaind-e2e -f dockerfiles/Dockerfile.e2e . --no-cache
$ go test -timeout 10m -v -run TestSedaGaiaIBCTransfer ./interchaintest

You should see a passing result:

--- PASS: TestSedaGaiaIBCTransfer (121.82s)
PASS
ok      github.com/sedaprotocol/seda-chain/interchaintest       122.459s

@jim380 jim380 changed the title Add Interchaintest [Interchaintest] Installment # 1 - Foundation Jan 5, 2024
@jim380 jim380 requested a review from hacheigriega January 5, 2024 07:10
@jim380 jim380 force-pushed the jay/inter-chain-tests-batch-1 branch 2 times, most recently from 8f6a129 to bd8bf36 Compare January 6, 2024 01:11
@jim380 jim380 force-pushed the jay/inter-chain-tests-batch-1 branch from 82b3aa6 to b238f1b Compare January 8, 2024 22:23
@jim380 jim380 marked this pull request as ready for review January 9, 2024 01:28
@hacheigriega hacheigriega self-requested a review January 9, 2024 16:02
@hacheigriega
Copy link
Member

I think because we don't need to migrate from params store, we can do without legacy params subspaces. What do you think?

From the ibc-go upgrade doc:
"For new chains which do not rely on migration of parameters from x/params, an expected interface has been added for each module. This allows chain developers to provide nil as the legacySubspace argument to NewKeeper functions." https://github.com/cosmos/ibc-go/releases/tag/v8.0.0

@jim380 jim380 merged commit 7723a75 into main Jan 9, 2024
5 of 7 checks passed
@jim380 jim380 deleted the jay/inter-chain-tests-batch-1 branch January 9, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants