Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test-e2e in CI #144

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix: test-e2e in CI #144

merged 2 commits into from
Jan 4, 2024

Conversation

jim380
Copy link
Contributor

@jim380 jim380 commented Jan 4, 2024

No description provided.

@jim380 jim380 changed the title fix: test-e2e fix: test-e2e in CI Jan 4, 2024
@jim380 jim380 requested a review from hacheigriega January 4, 2024 02:21
hacheigriega
hacheigriega approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@hacheigriega hacheigriega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the variable name was the issue? Thanks a ton for the fix!!

@jim380 jim380 merged commit 10d5239 into main Jan 4, 2024
6 checks passed
@jim380 jim380 deleted the jay/fix-test-e2e branch January 4, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacheigriega hacheigriega hacheigriega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jim380 @hacheigriega