Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine IBC Integration & app.go Refactor #138

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Refine IBC Integration & app.go Refactor #138

merged 3 commits into from
Jan 4, 2024

Conversation

jim380
Copy link
Contributor

@jim380 jim380 commented Dec 22, 2023

Motivation

(Write your motivation here)

Explanation of Changes

(Write your explanation here)

Testing

(Write your test plan here)

Related PRs and Issues

(Link your related PRs and Issues here)

@jim380 jim380 marked this pull request as draft December 22, 2023 08:47
@jim380 jim380 changed the title Possible IBC Fix & app.go Refactor Refine IBC Integration & app.go Refactor Dec 22, 2023
@jim380 jim380 marked this pull request as ready for review January 4, 2024 02:23
@hacheigriega
Copy link
Member

I get the following error:

./build/seda-chaind tendermint unsafe-reset-all
panic: TypeInfo already exists for proto.Message

goroutine 1 [running]:
github.com/tendermint/go-amino.(*Codec).setTypeInfo_nolock(0x1400070fe30, 0x14000d80240)
        github.com/tendermint/[email protected]/codec.go:342 +0x46c
github.com/tendermint/go-amino.(*Codec).RegisterInterface.func1(0x1400070fe30, 0x1056dbf10?)
        github.com/tendermint/[email protected]/codec.go:178 +0x7c
github.com/tendermint/go-amino.(*Codec).RegisterInterface(0x0?, {0x104ffde40, 0x0}, 0x0?)
        github.com/tendermint/[email protected]/codec.go:179 +0x74
github.com/cosmos/cosmos-sdk/codec.(*LegacyAmino).RegisterInterface(...)
        github.com/cosmos/[email protected]/codec/amino.go:179
github.com/cosmos/cosmos-sdk/types.RegisterLegacyAminoCodec(0x140001150b8)
        github.com/cosmos/[email protected]/types/codec.go:15 +0x3c
github.com/cosmos/cosmos-sdk/std.RegisterLegacyAminoCodec(0x0?)
        github.com/cosmos/[email protected]/std/codec.go:13 +0x20
github.com/sedaprotocol/seda-chain/app.NewApp({0x105697970, 0x1072e1820}, {0x1056b08d0, 0x1400128d440}, {0x0, 0x0}, 0x1, 0x102605a18?, {0x14000c370b0, 0x18}, ...)
        github.com/sedaprotocol/seda-chain/app/app.go:300 +0x134
github.com/sedaprotocol/seda-chain/cmd/seda-chaind/cmd.NewRootCmd()
        github.com/sedaprotocol/seda-chain/cmd/seda-chaind/cmd/root.go:59 +0x538
main.main()
        github.com/sedaprotocol/seda-chain/cmd/seda-chaind/main.go:14 +0x1c

Does this work on your side?

@jim380
Copy link
Contributor Author

jim380 commented Jan 4, 2024

I get the following error:

./build/seda-chaind tendermint unsafe-reset-all
panic: TypeInfo already exists for proto.Message

goroutine 1 [running]:
github.com/tendermint/go-amino.(*Codec).setTypeInfo_nolock(0x1400070fe30, 0x14000d80240)
        github.com/tendermint/[email protected]/codec.go:342 +0x46c
github.com/tendermint/go-amino.(*Codec).RegisterInterface.func1(0x1400070fe30, 0x1056dbf10?)
        github.com/tendermint/[email protected]/codec.go:178 +0x7c
github.com/tendermint/go-amino.(*Codec).RegisterInterface(0x0?, {0x104ffde40, 0x0}, 0x0?)
        github.com/tendermint/[email protected]/codec.go:179 +0x74
github.com/cosmos/cosmos-sdk/codec.(*LegacyAmino).RegisterInterface(...)
        github.com/cosmos/[email protected]/codec/amino.go:179
github.com/cosmos/cosmos-sdk/types.RegisterLegacyAminoCodec(0x140001150b8)
        github.com/cosmos/[email protected]/types/codec.go:15 +0x3c
github.com/cosmos/cosmos-sdk/std.RegisterLegacyAminoCodec(0x0?)
        github.com/cosmos/[email protected]/std/codec.go:13 +0x20
github.com/sedaprotocol/seda-chain/app.NewApp({0x105697970, 0x1072e1820}, {0x1056b08d0, 0x1400128d440}, {0x0, 0x0}, 0x1, 0x102605a18?, {0x14000c370b0, 0x18}, ...)
        github.com/sedaprotocol/seda-chain/app/app.go:300 +0x134
github.com/sedaprotocol/seda-chain/cmd/seda-chaind/cmd.NewRootCmd()
        github.com/sedaprotocol/seda-chain/cmd/seda-chaind/cmd/root.go:59 +0x538
main.main()
        github.com/sedaprotocol/seda-chain/cmd/seda-chaind/main.go:14 +0x1c

Does this work on your side?

good catch. I'm debugging.

@jim380
Copy link
Contributor Author

jim380 commented Jan 4, 2024

@hacheigriega I reverted the encoding config changes. It was registering proto's twice. We can save this for later when we officially migrate to v0.50

@hacheigriega hacheigriega self-requested a review January 4, 2024 21:10
hacheigriega
hacheigriega approved these changes Jan 4, 2024
View reviewed changes
app/app.go
@@ -1043,7 +1101,7 @@ func (app *App) RegisterAPIRoutes(apiSvr *api.Server, apiConfig config.APIConfig
nodeservice.RegisterGRPCGatewayRoutes(clientCtx, apiSvr.GRPCGatewayRouter)

// Register grpc-gateway routes for all modules.
app.BasicModuleManager().RegisterGRPCGatewayRoutes(clientCtx, apiSvr.GRPCGatewayRouter)
ModuleBasics.RegisterGRPCGatewayRoutes(clientCtx, apiSvr.GRPCGatewayRouter)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this causing a specific issue?

@jim380 jim380 merged commit 399da75 into main Jan 4, 2024
6 checks passed
@jim380 jim380 deleted the jay/hook-up-ibc branch January 4, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacheigriega hacheigriega hacheigriega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jim380 @hacheigriega