Add Ability to Change max-wasm-size via Governance #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim380
changed the title
jim380
changed the title
jim380
changed the title
|
LGTM but wouldn't this have to be changed again once we migrate to collections? |
Yeah there'd be some structural changes, but mostly around keeper. |
| if m.GetAuthority() != req.Authority { | ||
| return nil, fmt.Errorf("invalid authority; expected %s, got %s", m.GetAuthority(), req.Authority) | ||
| } | ||
|
|
There was a problem hiding this comment.
v0.50 recommends that we validate message here
| } | ||
|
|
||
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
| if err := m.SetParams(ctx, req.Params); err != nil { |
There was a problem hiding this comment.
validate params before setting?
hacheigriega
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR attempts to achieve the followings:
max-wasm-sizeat compile timemax-wasm-sizevia governanceCloses #62