Replace .netrc with Env Var in Dockerfile #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR attemps to use environment variables in Dockerfile to pass sensitive information like GitHub Personal Access Tokens (PATs) has several advantages over using a
.netrc
file for the following reasons:Security: Environment variables are ephemeral and only exist for the duration of the Docker build process. They are not stored in any file that could be accidentally committed to a repository or left around on a filesystem
Flexibility: Environment variables can be easily changed without modifying any files. This is particularly useful in CI/CD environments where you might want to use different PATs for different builds or stages
Portability: Environment variables are a standard feature of all Unix-like operating systems and are supported by all CI/CD systems. On the other hand, the
.netrc
file is a feature of the netrc library which is not universally supportedBest Practices: It's a common best practice in Docker and 12-factor app methodology to pass configuration to applications using environment variables
Tests