chore: address review comments

sedaprotocol · Nov 1, 2024 · a2971b5 · a2971b5
1 parent 834ccf5
commit a2971b5
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 12 deletions.
diff --git a/app/app.go b/app/app.go
@@ -649,7 +649,6 @@ func NewApp(
 	)
 
 	app.PubKeyKeeper = *pubkeykeeper.NewKeeper(
-		appCodec,
 		runtime.NewKVStoreService(keys[pubkeytypes.StoreKey]),
 		app.StakingKeeper,
 		authcodec.NewBech32Codec(sdk.GetConfig().GetBech32ValidatorAddrPrefix()),

diff --git a/app/utils/seda_keys.go b/app/utils/seda_keys.go
@@ -49,10 +49,7 @@ var sedaKeyGenerators = map[SEDAKeyIndex]privKeyGenerator{
 var sedaKeyValidators = map[SEDAKeyIndex]pubKeyValidator{
 	SEDAKeyIndexSecp256k1: func(pubKey []byte) bool {
 		x, _ := elliptic.Unmarshal(ethcrypto.S256(), pubKey)
-		if x == nil {
-			return false
-		}
-		return true
+		return x != nil
 	},
 }
 
@@ -223,8 +220,7 @@ func LoadSEDASigner(loadPath string) (SEDASigner, error) {
 	return &sedaKeys{keys: keys}, nil
 }
 
-// Sign hashes the given input using Keccak-256 and signs the resulting
-// hash with the key at the given index.
+// Sign signs a 32-byte digest with the key at the given index.
 func (s *sedaKeys) Sign(input []byte, index SEDAKeyIndex) ([]byte, error) {
 	var signature []byte
 	var err error

diff --git a/x/pubkey/keeper/keeper.go b/x/pubkey/keeper/keeper.go
@@ -7,7 +7,6 @@ import (
 	"cosmossdk.io/core/address"
 	storetypes "cosmossdk.io/core/store"
 
-	"github.com/cosmos/cosmos-sdk/codec"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
 
@@ -23,7 +22,7 @@ type Keeper struct {
 	pubKeys collections.Map[collections.Pair[[]byte, uint32], []byte]
 }
 
-func NewKeeper(cdc codec.BinaryCodec, storeService storetypes.KVStoreService, sk types.StakingKeeper, validatorAddressCodec address.Codec) *Keeper {
+func NewKeeper(storeService storetypes.KVStoreService, sk types.StakingKeeper, validatorAddressCodec address.Codec) *Keeper {
 	if validatorAddressCodec == nil {
 		panic("validator address codec is nil")
 	}

diff --git a/x/pubkey/keeper/msg_server_test.go b/x/pubkey/keeper/msg_server_test.go
@@ -7,6 +7,7 @@ import (
 	gomock "go.uber.org/mock/gomock"
 
 	"github.com/cometbft/cometbft/crypto/secp256k1"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
 	stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"

diff --git a/x/pubkey/types/tx.go b/x/pubkey/types/tx.go
@@ -5,9 +5,7 @@ import (
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
 )
 
-var (
-	_ sdk.Msg = &MsgAddKey{}
-)
+var _ sdk.Msg = &MsgAddKey{}
 
 func (m *MsgAddKey) Validate() error {
 	if m.ValidatorAddr == "" {