-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring non root sudoer for molecule tests #96
Conversation
a1d33d1
to
91f814f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks a lot for the PR. It looks good overall, but I left some comments inline to address. Can you PTAL?
29448be
to
d5baf9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this looks really good, thanks for all the fixes. I noticed one more place where we could improve, I'll approve this PR once that is done. Thanks!
It seems that something is wrong with the way password is provided/used. From the failed task:
|
dbad4da
to
19f6222
Compare
OIDC instance down so CI won't pass + createtree container fails to spin up on centOS but is fine on RHEL. Will test again once identity instance is back to remove an outside factor in failure but all works as it should on a RHEL machine. |
19f6222
to
b666c4a
Compare
cae303f
to
b1850e3
Compare
molecule/testing_user_setup.yaml
Outdated
create_home: yes | ||
|
||
- name: Set password for testingUser | ||
ansible.builtin.shell: echo {{ item.password }} | passwd --stdin {{ item.user }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually setting the password, using user.password previously resulted in constant password errors for some reason
I constantly ran into the createtree issue before today, but after rebasing with the new Dex OIDC config + changing a small discrepancy it seems to work fine? Still not sure what the underlying issue was |
1627670
to
c2fca54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, LGTM. Thanks!
Adding Redis config which I forgot in initial scenario PR for user_provided
Adding non-root sudoer configuration for our scenario tests to emulate a real user environment
Changed shell commands to ansible collections, such as lineinfile
(Waiting for tf access so I can personally snoop around our molecule scenarios on a tf vm before merge)