Fix auth failure on one-way TLS #1167
Open
+57
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
MasterSkepticista
force-pushed
the
karansh1/client_auth_bug
branch
from
b55c667
to
bede7a4
Compare
…fault Signed-off-by: Shah, Karan <[email protected]>
…fault Signed-off-by: Shah, Karan <[email protected]>
There was a problem hiding this comment.
Is updating the usage of these keys in tests not in scope for this PR? Tests Ref.
Yes. @payalcha suggested applying those changes in a separate PR (after this is merged). |
teoparvanov
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Great, thanks @MasterSkepticista !
PS: as discussed offline, don't forget to run the OpenFL-Security CI against this branch
Signed-off-by: Shah, Karan <[email protected]>
rahulga1
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Internal changes for ofl-s pending, do not merge.
Changelog:
tls -> use_tlsin the plan.disable_client_auth -> require_client_authin the plan. NOTE: This change has been made to reduce cognitive overhead of knowing how to enable mTLS in communication between the client-server.disable_client_auth=False, tls=True) meant enabling mTLS.require_client_auth=True, use_tls=True) will enable mTLS.logger.warn -> logger.warningto hide deprecation warningsTested with 4 combinations of two updated flags.