Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow based tutorial for Tensorflow CNN training on MNIST data #1164

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

snehal-das
Copy link
Contributor

This PR adds an example for training a Tensorflow CNN to recongnise handwritten digits using an MNIST dataset.

Copy link
Collaborator

@teoparvanov teoparvanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a couple of minor comments (in addition to @rahulga1's suggestions)!

openfl-tutorials/experimental/Keras_MNIST_with_CPU.ipynb Outdated Show resolved Hide resolved
openfl-tutorials/experimental/Keras_MNIST_with_CPU.ipynb Outdated Show resolved Hide resolved
openfl-tutorials/experimental/Keras_MNIST_with_CPU.ipynb Outdated Show resolved Hide resolved
openfl-tutorials/experimental/Keras_MNIST_with_CPU.ipynb Outdated Show resolved Hide resolved
Copy link
Collaborator

@theakshaypant theakshaypant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just adding on to Teo's suggestion.

openfl-tutorials/experimental/Keras_MNIST_with_CPU.ipynb Outdated Show resolved Hide resolved
@teoparvanov
Copy link
Collaborator

teoparvanov commented Nov 21, 2024

Hi @snehal-das , could you address the DCO job failure, by signing all your commits?

git commit -s -m "..."

@rahulga1 rahulga1 merged commit 5392d9f into securefederatedai:develop Nov 26, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants