Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating to new api #18

Merged
merged 3 commits into from
Jan 8, 2023
Merged

migrating to new api #18

merged 3 commits into from
Jan 8, 2023

Conversation

skewballfox
Copy link
Collaborator

closes #16 and unblocks #15 (right now the only arguments against publishing an initial version is migrating the api). We might want to run a few sanity test in the benchmark repo (just confirming the output is the same as speechpy) but I'd say its achieved MVP status after this gets merged

@skewballfox skewballfox marked this pull request as ready for review January 8, 2023 18:25
@skewballfox
Copy link
Collaborator Author

Migration to new builder pattern api is finished, when tested python side it shaves .03 seconds off repeated calls

@skewballfox skewballfox merged commit 215cdd2 into master Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set up python functions to cache if only signal changes
1 participant