Set AUTOBUILD_VCS_BRANCH for an autobuild package. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a tag build used to release a package, github reports the tag name rather than the branch to which it corresponds. Look up the corresponding branch and pass it to autobuild as AUTOBUILD_VCS_BRANCH, which will set the vcs_branch field in the package's autobuild-package.xml's package_description. Otherwise, vcs_branch is reported for every build of every package as "HEAD".
brad-linden
approved these changes
Dec 18, 2023
| run: | | ||
| # in real use, 'git branch -r --contains' should produce a single line, | ||
| # but our self-tests can emit more than one | ||
| branch="$(git branch -r --contains ${{ steps.sha.outputs.long }} | head -n 1)" |
There was a problem hiding this comment.
is there an advantage of this git incantation over git rev-parse --abbrev-ref HEAD which has been the standard one that I've included in my shell prompt since time immemorial?
There was a problem hiding this comment.
Likely to report detached HEAD. git branch --contains <hash> reports detached HEAD unless you also supply -r.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to be able to look up the source branch from which a given autobuild package tarball was built. If
AUTOBUILD_VCS_BRANCHis set in autobuild's environment, that gets stored in the package'sautobuild-package.xml. Without it, every autobuild package's GitHub build's branch is reported as "HEAD".