Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependent version of bytes #90

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Conversation

DarumaDocker
Copy link
Member

No description provided.

Copy link
Member

juntao commented Dec 22, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit aa2885e8cb923a83aa267ecf66c5a165b9aa9f1c

Summary of changes:

  1. The package "wasmedge_wasi_socket" version has been updated from "0.5.2" to "0.5.3".

  2. The dependency for the "bytes" crate has been changed from version "1.4.0" to version "1".

Potential Issues:

  1. The version for the bytes dependency has been decreased from "1.4.0" to "1". This might cause issues if the software relies on features added in version "1.4.0" of the bytes package.

  2. Instead of mentioning a specific patch version, the developer has mentioned the major version "1" for bytes. This change can potentially introduce breaking changes if a new minor or patch update for bytes is published, which is non-backward compatible.

It would be advisable for the developer to consider these potential issues before merging these changes. They might want to review the package version management and avoid using a less specific dependency tag. It would be better to mention the specific minor and patch versions or use the "~=" or "^" prefixes for dependency tags in Cargo.toml to handle the updates in a controlled manner.

@juntao
Copy link
Member

juntao commented Dec 22, 2023

Shall we publish it to crates.io?

@L-jasmine
Copy link
Contributor

Shall we publish it to crates.io?

yes

@DarumaDocker
Copy link
Member Author

@juntao We don't have authority to merge.

@juntao juntao merged commit 880e99e into second-state:main Dec 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants