-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request for adding hash based redis commands implementation in django-redis #41
base: master
Are you sure you want to change the base?
Conversation
Hi sebleier, Thanks. |
Yeah +1 for this, though it should be noted that the maximum number of entries a hash can have while still being encoded efficiently is around 1000 according to this: http://instagram-engineering.tumblr.com/post/12202313862/storing-hundreds-of-millions-of-simple-key-value-pairs |
It's 2014, so you kinda do say no.
Redis backend has this feature, the library does not, so it essentially limits Redis's functionality. Hashes are useful to decrease cache entries and thus requests to cache drastically. |
is there any plan to get hash support in at some point or I should write my own? This is huge limitation |
@aleksandra-tarkowska for what it's worth, we've moved to https://github.com/niwinz/django-redis :-) |
thx, but I still don't see hset, except raw client ? |
@aleksandra-tarkowska yup, only raw client. Which does have hset and other stuff: http://redis-py.readthedocs.io/en/latest/ |
I have added hget, hset, hget_many, hset_many and hincr implementation. Please review it. Thanks.