Add a way to choose the protocol for pickle. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d reverted a few unneeded changes. This also handles the key better internally to prevent multiple "making" of the key.
We can't inherit a class from a basestring and instantiate it, so I changed the base class to 'object' so we can still to the type checking. I also discovered a bug with the Django 1.3 compatibility work. In the incr_version method, we were using the Redis's rename function to move the key, but in Redis 2.0 you cannot rename a volitile key. Added some moar authors
Default is 0, and change it by passing another protocol (1 or 2) in the OPTIONS dict of your cache declaration Based on arshaver@2042168
|
FWIW, I think this is a great idea as it would reduce the size of each cache item drastically. The default pickle protocol |
|
I added most of this to the 1.0 branch I'm working on. Thanks for your work on this and sorry of lollygaggin' :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
To have a more efficient storage i needed to use another protocol for pickle, so i added a way to change the default one.
Default is 0, and change it by passing another protocol (1 or 2) in the
OPTIONS dict of your cache declaration
This work is based on
arshaver@2042168
Twidi
PS : sorry for the noise in the list of commits, i don't now how to avoid this, but the diff is correct