Confirm support of django 1.11 and python 2.7 to 3.* #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehybird
commented
Sep 12, 2017
joehybird
commented
- Add specific target for django 1.11 in travis configuration.
- Fix problem with int => long conversion in python 2.7
- Maybe the problems with travis builds comes from fast set/get calls in unit tests (async issue ?). I had no time to investigate sorry.
timgraham
reviewed
Aug 6, 2018
redis_cache/sharder.py
Outdated
| # in get_slot() if the hash value overflows integer a LONG is returned ! | ||
| # and LONG not exist in python 3.x | ||
| try: | ||
| NUMBER_TYPES = (int, long) |
There was a problem hiding this comment.
Use django.utils.six.integer_types rather than reimplementing it.
joehybird
force-pushed
the
master
branch
2 times, most recently
from
47c21a2 to
e1fd32a
Compare
|
I have a serious problem with redis-server, the requests seems to fail randomly (are the tests synchronous ?) |
…aly). Fix issue due to integer overflow and python < 3 (converted to long). Fix redis version in order to have SCAN command.
joehybird
force-pushed
the
master
branch
3 times, most recently
from
1e22e46 to
68f2a41
Compare
|
@timgraham, it seems to pass but I got some issues between pyyaml and python 3.7 and had to upgrade this dependency. |
|
Okay. By the way, I'm not a maintainer of this project. |
|
Ok, I should ping @sebleier instead... Thanks for the help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.