Use asynchronous operations everywhere to avoid blocking the main thread #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
commented
Nov 22, 2024
Comment on lines
-1139
to
-1149
| function promisifySave(nodeStyleFunction) { | ||
| return function () { | ||
| const args = Array.prototype.slice.call(arguments); | ||
| return new Promise(function (resolve) { | ||
| args.push(function (err, data) { | ||
| resolve(data); | ||
| }); | ||
| nodeStyleFunction.apply(null, args); | ||
| }); | ||
| }; | ||
| } |
There was a problem hiding this comment.
This utility function had exactly one usage, where now a .catch(() => '') is utilized in its place.
|
Just fyi @sebhildebrandt systeminformation causes major performance issues and event loop deadlocks when used in server applications. This PR fixes it. https://nodejs.org/en/learn/asynchronous-work/dont-block-the-event-loop We're running this fork at @getumbrel with great results but we'd love to come back to upstream once this is merged 🙏 |
|
@sebhildebrandt would you be able to include this in the next release? |
|
@Spartan-Hex-Shadow, @dcodeIO , @lukechilds ... the next major release (6.0) is a complete rewrite (TS) where we do not have any sync functions. This should then be solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all blocking operations (
child_process.execSyncandfs.readSync) from the library and replaces them with asynchronous equivalents while keeping the public API intact.The diff is intentionally boring, focusing solely on this change and minor related cleanup to minimize the risk of introducing accidental breakage.
Fixes #873. Keep it up!