Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the Cobertura coverage report #957

Open
wants to merge 1 commit into
base: 9.2
Choose a base branch
from

Conversation

jhoffland
Copy link

@jhoffland jhoffland commented Nov 8, 2022

The format of the Cobertura report did not match the Cobertura document definition. For example in some cases, the required attribute name of package and the required attribute signature of method was empty.
Resulting in tools like Jenkins not being able to interpret the report.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #957 (c99f329) into 9.2 (709ee60) will decrease coverage by 0.17%.
The diff coverage is 98.81%.

❗ Current head c99f329 differs from pull request most recent head f0a6126. Consider uploading reports for the commit f0a6126 to get more accurate results

@@             Coverage Diff              @@
##                9.2     #957      +/-   ##
============================================
- Coverage     84.29%   84.11%   -0.18%     
- Complexity     1178     1235      +57     
============================================
  Files            59       65       +6     
  Lines          4215     3519     -696     
============================================
- Hits           3553     2960     -593     
+ Misses          662      559     -103     
Impacted Files Coverage Δ
src/Report/Cobertura/CoberturaLine.php 93.33% <93.33%> (ø)
src/Report/Cobertura/CoberturaClass.php 98.07% <98.07%> (ø)
src/Report/Cobertura/CoberturaCoverage.php 99.00% <99.00%> (ø)
src/Report/Cobertura.php 57.14% <100.00%> (-39.97%) ⬇️
src/Report/Cobertura/CoberturaElement.php 100.00% <100.00%> (ø)
src/Report/Cobertura/CoberturaMethod.php 100.00% <100.00%> (ø)
src/Report/Cobertura/CoberturaPackage.php 100.00% <100.00%> (ø)
src/Driver/Driver.php 85.71% <0.00%> (-2.53%) ⬇️
src/Report/Xml/Report.php 93.54% <0.00%> (-2.20%) ⬇️
...c/StaticAnalysis/ExecutableLinesFindingVisitor.php 97.00% <0.00%> (-1.91%) ⬇️
... and 36 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jhoffland jhoffland marked this pull request as ready for review November 8, 2022 13:46
@jhoffland jhoffland requested a review from mvorisek November 11, 2022 07:46
@jhoffland
Copy link
Author

Hi @sebastianbergmann, what is the best way to get this PR reviewed and merged?

@sebastianbergmann
Copy link
Owner

This branch cannot be rebased due to conflicts.

@sebastianbergmann
Copy link
Owner

This branch cannot be rebased due to conflicts.

I hope to have time next week to look into this.

@jhoffland
Copy link
Author

This branch cannot be rebased due to conflicts.

Yesterday I merged the 9.2 branch into the branch of this PR and resolved the merge conflicts.

I hope to have time next week to look into this.

That would be nice! Thanks in advance.

@sebastianbergmann
Copy link
Owner

Yesterday I merged the 9.2 branch into the branch of this PR and resolved the merge conflicts.

GitHub disagrees:

This branch cannot be rebased due to conflicts

Sorry :(

@jhoffland jhoffland force-pushed the improved-cobertura-report branch from 14dcad3 to d26df1b Compare November 18, 2022 12:57
@jhoffland
Copy link
Author

My apologies for the confusion. I just squased the commits and rebased the branch.

@jhoffland
Copy link
Author

Is there something I can do to get this PR merged? I think everything is ready now.

@sebastianbergmann
Copy link
Owner

Nothing right now, I just need to find the time to review it.

@jhoffland jhoffland force-pushed the improved-cobertura-report branch from d26df1b to c99f329 Compare December 5, 2022 18:21
@jhoffland jhoffland force-pushed the improved-cobertura-report branch from c99f329 to 0221768 Compare December 14, 2022 15:20
@jhoffland jhoffland force-pushed the improved-cobertura-report branch from 0221768 to 51de9c8 Compare December 22, 2022 14:07
@jhoffland jhoffland force-pushed the improved-cobertura-report branch from 51de9c8 to f0a6126 Compare December 22, 2022 14:48
@Zjmainstay
Copy link

Is there any new progress on this PR? Need this fix.

@sebastianbergmann
Copy link
Owner

I am sorry, but I cannot look at this before the conflicts are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants