Fix: Pad lines in code coverage report only when colors are shown #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 10.1 #1032 +/- ##
============================================
+ Coverage 84.03% 84.90% +0.87%
Complexity 1199 1199
============================================
Files 71 71
Lines 4252 4253 +1
============================================
+ Hits 3573 3611 +38
+ Misses 679 642 -37 ☔ View full report in Codecov by Sentry. |
localheinz
force-pushed
the
fix/padding
branch
2 times, most recently
from
29d5e6b to
2a87404
Compare
localheinz
commented
Mar 9, 2024
src/Report/Text.php
Outdated
Comment on lines
307
to
304
| private function format(string $color, int $padding, false|string $string): string | ||
| private function format(string $color, false|string $string): string | ||
| { | ||
| $reset = $color ? self::COLOR_RESET : ''; | ||
|
|
||
| return $color . str_pad((string) $string, $padding) . $reset . PHP_EOL; | ||
| return $color . (string) $string . $reset . PHP_EOL; |
There was a problem hiding this comment.
Do you remember what purpose the padding serves here?
There was a problem hiding this comment.
A quick conversation with @sebastianbergmann confirms that this is used for rendering blocks
Before
After
There was a problem hiding this comment.
It's ancient from sebastianbergmann/phpunit#949
There was a problem hiding this comment.
Thank you, @dvdoug!
localheinz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request